Clean-up score #10
Merged
Clean-up score #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
force-pushed
the
get-rid-of-score
branch
from
1df265a to
7f06327
Compare
MartinquaXD
approved these changes
Apr 4, 2024
sunce86
approved these changes
Apr 5, 2024
sunce86
added a commit
to cowprotocol/services
that referenced
this pull request
Apr 5, 2024
# Description Fixes #2493 Fixes #1494 Important notes: 1. ~Removed risk parameter config from solvers - requires cleanup of "riskParameters" in infrastructure repo~ - will be done in a separate PR 2. Solvers api "score" field is optional until solvers update their responses - will be removed completely #2588. Follow ups: 1. cleanup of "riskParameters" in infrastructure repo 3. Update gnosis solvers response https://github.com/gnosis/solvers/blob/main/src/api/routes/solve/dto/solution.rs - gnosis/solvers#10 4. Add more score errors to notify endpoint - #2597 ## How to test Existing tests. No change in behaviour is expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the cowprotocol/services#2585